autophagy commented on a change in pull request #18949:
URL: https://github.com/apache/flink/pull/18949#discussion_r823656608
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -571,6 +585,10 @@ protected HighAvailabilityServices
createHighAvailabilityServices(
}
}
+ public HighAvailabilityServices getHaServices() {
Review comment:
Could this be protected, rather than public? It's only being used in a
subclass.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -1175,6 +1193,7 @@ protected RpcService createLocalRpcService(Configuration
configuration, RpcSyste
private void terminateMiniClusterServices() throws Exception {
// collect the first exception, but continue and add all successive
// exceptions as suppressed
+ LOG.info("term start");
Review comment:
What is the purpose of logging here? It feels like debug logging but
could you clarify if not?
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -1219,6 +1238,7 @@ private void terminateMiniClusterServices() throws
Exception {
throw exception;
}
}
+ LOG.info("term stop");
Review comment:
Same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
