FilKarnicki commented on pull request #307: URL: https://github.com/apache/flink-statefun/pull/307#issuecomment-1064082956
Hi @igalshilman I created some additional changes to StatefulFunctionsJob because the args passed to the main method weren't used to create the streaming env, and they weren't used to validate the settings (meaning that the override for embedded mode wasn't seen by the validator). I'm wondering if the new behaviour could be breaking to existing users... That said, I think that using passed args to generate the env is the right thing to do. Especially for embedded users, who will otherwise not be able to (for example) set checkpointing interval durations per job. Please let me know what you think Fil -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
