XComp opened a new pull request #19047:
URL: https://github.com/apache/flink/pull/19047
## What is the purpose of the change
The Application Mode relies on the `JobResultStore` for recovery. Nothing
will be recovered if the job is in dirty state but globally terminated. That
will just trigger the cleanup. But we didn't cover the case where there's a
clean entry in the `JobResultStore`. This lead to the Application just
terminating successfully without any indication to the user that the job didn't
run.
This PR changes the behavior in a way that a
`DuplicateJobSubmissionException` with a meaningful error message is thrown
instead.
## Brief change log
* `ApplicationDispatcherBootstrap` constructor gets a new parameter that
enables us to pass in the JobResultStore check as a callback
* This check can be used to issue an error before submitting the application
again.
## Verifying this change
* `ApplicationDispatcherBootstrapTest` and
`ApplicationDispatcherBootstrapITCase` were extended to cover this issue
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
