AHeise commented on pull request #18790: URL: https://github.com/apache/flink/pull/18790#issuecomment-1064841625
The analysis of the problem and the solution are great. Ideally, I'd just embed it in `SourceReaderBase#addSplits` and eagerly call `ReaderOutput#createOutputForSplit` but unfortunately we don't have access to the main `ReaderOutput` there (something that we should change, but it's public and it's high noon :/). It still feels hacky to call `ReaderOutput#createOutputForSplit` twice but the contract says that it will only recreate it once, so I guess it's okay. Could you please create a follow-up ticket for that? I'll take an in-depth look at your solution now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
