Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2355#discussion_r75305729
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/SlidingEventTimeWindows.java
 ---
    @@ -102,7 +105,32 @@ public String toString() {
         * @return The time policy.
         */
        public static SlidingEventTimeWindows of(Time size, Time slide) {
    -           return new SlidingEventTimeWindows(size.toMilliseconds(), 
slide.toMilliseconds());
    +           return new SlidingEventTimeWindows(size.toMilliseconds(), 
slide.toMilliseconds(),0);
    +   }
    +
    +   /**
    +    *  Creates a new {@code SlidingEventTimeWindows} {@link 
WindowAssigner} that assigns
    +    *  elements to time windows based on the element timestamp and offset.
    +    *<p>
    +    *     For example, if you want window a stream by hour,but window 
begins at the 15th minutes
    +    *     of each hour, you can use {@code 
of(Time.hours(1),Time.minutes(15))},then you will get
    --- End diff --
    
    Missing space after comma.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to