LadyForest commented on a change in pull request #41:
URL: https://github.com/apache/flink-table-store/pull/41#discussion_r824469259
##########
File path:
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/TableStoreFactory.java
##########
@@ -65,8 +69,8 @@
@Override
public void onCreateTable(Context context, boolean ignoreIfExists) {
- Map<String, String> options = context.getCatalogTable().getOptions();
Review comment:
From the developer's perspective, we all know that `#onCreate` and
`#onDrop` get called only after `#enrichOptions` is executed. While from the
API layer, it's hard to tell they have an order (except taking a reference to
Flink's codebase). That's why I change the name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
