matriv commented on a change in pull request #19045:
URL: https://github.com/apache/flink/pull/19045#discussion_r824576629
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/CodeGenUtils.scala
##########
@@ -477,40 +477,26 @@ object CodeGenUtils {
case Some(writer) =>
// use writer to set field
val writeField = binaryWriterWriteField(ctx, indexTerm, fieldTerm,
writer, fieldType)
- if (ctx.nullCheck) {
- s"""
- |${fieldExpr.code}
- |if (${fieldExpr.nullTerm}) {
- | ${binaryWriterWriteNull(indexTerm, writer, fieldType)};
- |} else {
- | $writeField;
- |}
- """.stripMargin
- } else {
- s"""
- |${fieldExpr.code}
- |$writeField;
- """.stripMargin
- }
+ s"""
Review comment:
You mean, to have the similar code but instead of checking the
`ctx.nullCheck`, check the nullability of the field and if it's not null then
avoid the extra code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
