maxCodeVector commented on a change in pull request #18854:
URL: https://github.com/apache/flink/pull/18854#discussion_r824693213
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java
##########
@@ -130,15 +132,16 @@ public void
createJobManagerComponent(KubernetesJobManagerSpecification kubernet
@Override
public CompletableFuture<Void> createTaskManagerPod(KubernetesPod
kubernetesPod) {
Review comment:
I was also thinking about adding some tests but just didn't have an idea
that how I could test that one variable is moved from local to global. Or maybe
it is already covered by the existing tests (such as
Fabric8FlinkKubeClientTest#testCreateFlinkTaskManagerPod() )?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
