realdengziqi commented on pull request #18982: URL: https://github.com/apache/flink/pull/18982#issuecomment-1065140341
@zjuwangg Thanks for the review, again! We checked the unit-test module, which located at `org.apache.flink.streaming.runtime.operators.windowing.TimeWindowTest`. Turns out it hasn't cover the test for negative timestamp cases. So we add additional test cases by simply negative the original positive-values only test cases. During the unit test, we found out that our calculation will make the window exclude the start time, which violated the window assignment principle unfortunately. So, considered the readability and correctness, we borrowed the calculation method inside the `org.apache.flink.table.runtime.operators.window.grouping.WindowsGrouping` method eventually in our code. **Considered the code-reference mentioned above, looking forward to have a further discussions with you**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
