XComp commented on a change in pull request #19047:
URL: https://github.com/apache/flink/pull/19047#discussion_r824739740
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -428,6 +428,12 @@ private void stopDispatcherServices() throws Exception {
try {
if (isDuplicateJob(jobGraph.getJobID())) {
+ if (isGloballyTerminatedAndCleanedUp(jobGraph.getJobID())) {
+ log.warn(
+ "A job having the ID {} is already in
globally-terminal state and marked as clean in the JobResultStore. No execution
is going to happen.",
+ jobGraph.getJobID());
Review comment:
Fair enough. But I'm gonna add the warning then even for dirty jobs
because it still makes sense.
We don't have the `JobStatus` at that point available. And I'm hesitant to
update the interface for that one log message. Instead, I listed all
globally-terminal states in the log message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
