rkhachatryan opened a new pull request #19062:
URL: https://github.com/apache/flink/pull/19062


   This is an alternative version of #19050 that solves the problem using 
`MailboxExecutor`.
   
   ## What is the purpose of the change
   
   ```
   When a task thread tries to schedule an upload, it might wait for available 
capacity.
   Capacity is released by the uploading thread on upload completion.  After 
releasing,
   it must notify the task thread about the completion.
   Both task and uploading thread acquire FsStateChangelogWriter.lock. That 
causes
   a deadlock if uploader releases capacity insufficient for task thread to 
proceed.
   
   This change removes the lock and makes uploader thread to use mailbox 
actions.
   ```
   
   ## Verifying this change
   
   `FsStateChangelogStorageTest.testDeadlockOnUploadCompletion`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to