Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75331224
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/ConnectionMonitor.scala
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.mesos.scheduler
+
+import akka.actor.{Actor, FSM, Props}
+import grizzled.slf4j.Logger
+import org.apache.flink.configuration.Configuration
+import org.apache.flink.mesos.scheduler.ConnectionMonitor._
+import org.apache.flink.mesos.scheduler.messages._
+
+import scala.concurrent.duration._
+
+/**
+ * Actively monitors the Mesos connection.
+ */
+class ConnectionMonitor() extends Actor with FSM[FsmState, Unit] {
+
+ val LOG = Logger(getClass)
+
+ startWith(StoppedState, None)
+
+ when(StoppedState) {
+ case Event(msg: Start, _) =>
+ LOG.info(s"Connecting to Mesos...")
+ goto(ConnectingState)
+ }
+
+ when(ConnectingState, stateTimeout = CONNECT_RETRY_RATE) {
+ case Event(msg: Stop, _) =>
+ goto(StoppedState)
+
+ case Event(msg: Registered, _) =>
+ LOG.info(s"Connected to Mesos as framework ID
${msg.frameworkId.getValue}.")
+ LOG.debug(s" Master Info: ${msg.masterInfo}")
+ goto(ConnectedState)
+
+ case Event(msg: ReRegistered, _) =>
+ LOG.info("Reconnected to a new Mesos master.")
+ LOG.debug(s" Master Info: ${msg.masterInfo}")
+ goto(ConnectedState)
+
+ case Event(StateTimeout, _) =>
+ LOG.warn("Unable to connect to Mesos; still trying...")
+ stay()
+ }
+
+ when(ConnectedState) {
+ case Event(msg: Stop, _) =>
+ goto(StoppedState)
+
+ case Event(msg: Disconnected, _) =>
+ LOG.warn("Disconnected from the Mesos master. Reconnecting...")
+ goto(ConnectingState)
+ }
+
--- End diff --
My rationale has been to let the default handling occur for unhandled
events. When I do use the `whenUnhandled` block, it is for common code. Do
tell if you see an event I should be handling, or I otherwise misunderstood
your comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
