Github user wenlong88 commented on the issue:
https://github.com/apache/flink/pull/2381
Hi, @tillrohrmann
1. It looks good if you think it is not a bit deal that the interface
RpcGateway contains functions defined for specific business logic and functions
defined for frameworks logic which right now only contains `getAddress`. I
treat it some kind of weird because I think the RpcGateway interface is the
business logic protocol of a RPC server, just like what we do in hadoop rpc
framework which also defines a interface to define what can do for a RPC server
like the RPC abstraction here.
2. I find that in current AkkaRpcService has another problem that if we use
a RpcService to get a Endpoint's self address, but the endpoint is not created
by the RpcService, we will get a wrong too, just like the example you make. It
need to do some check if we want to reserve the function. and you commit solve
the problem too.
3. Sorry for the codes left behind in last revert. I have removed it. But
I think if the concern in 1 is not a problem, your solution is better, and the
PR can be discarded
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
