[
https://issues.apache.org/jira/browse/FLINK-4231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15426716#comment-15426716
]
ASF GitHub Bot commented on FLINK-4231:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2272#discussion_r75338445
--- Diff:
flink-optimizer/src/test/java/org/apache/flink/optimizer/DistinctCompilationTest.java
---
@@ -71,8 +71,8 @@ public void testDistinctPlain() {
assertEquals(reduceNode,
sinkNode.getInput().getSource());
// check that both reduce and combiner have the same
strategy
- assertEquals(DriverStrategy.SORTED_GROUP_REDUCE,
reduceNode.getDriverStrategy());
- assertEquals(DriverStrategy.SORTED_GROUP_COMBINE,
combineNode.getDriverStrategy());
+ assertEquals(DriverStrategy.SORTED_REDUCE,
reduceNode.getDriverStrategy());
+ assertEquals(DriverStrategy.SORTED_PARTIAL_REDUCE,
combineNode.getDriverStrategy());
--- End diff --
Add a test that sets a `CombineHint.HASH` and check that the `combineNode`
driver strategy is `HASHED_PARTIAL_REDUCE`?
> Switch DistinctOperator from GroupReduce to Reduce
> --------------------------------------------------
>
> Key: FLINK-4231
> URL: https://issues.apache.org/jira/browse/FLINK-4231
> Project: Flink
> Issue Type: Improvement
> Components: Java API
> Affects Versions: 1.1.0
> Reporter: Greg Hogan
> Assignee: Greg Hogan
>
> As discussed in FLINK-3279, rewriting {{DistinctOperator}} to a
> {{ReduceFunction}} rather than the current {{GroupReduceFunction}} allows the
> user to set the {{CombineHint}} and choose a hash-based, sort-based, or no
> combiner.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
