alpreu opened a new pull request #19085:
URL: https://github.com/apache/flink/pull/19085


   ## What is the purpose of the change
   
   In 1.15 we ported the Elasticsearch sink to the new unified Sink interface. 
We initially did not port over the `ActionFailureHandler` as we wanted to 
deprecate it. When release-testing the Sink we found out that users depend on 
having the customizable FailureHandler so we want to re-introduce it to the 
sink.
   
   
   ## Brief change log
   
     - Added ActionFailureHandler back, adding the failed requests in the 
ElasticsearchWriter
     - Wrote a unit test that simulates the logic from the 
`Elasticsearch7Example` E2E Test.
     - Updated the docs
   
   
   ## Verifying this change
   
   This change can be tested with the newly introduced unit test, as well as 
the old E2E test.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (**yes** / no)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't 
know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (**yes** / no)
     - If yes, how is the feature documented? (not applicable / **docs** / 
JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to