syhily commented on a change in pull request #18406:
URL: https://github.com/apache/flink/pull/18406#discussion_r827822175



##########
File path: 
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/reader/deserializer/PulsarDeserializationSchema.java
##########
@@ -76,7 +76,10 @@ default void open(InitializationContext context) throws 
Exception {
      * @param message The message decoded by pulsar.
      * @param out The collector to put the resulting messages.
      */
-    void deserialize(Message<byte[]> message, Collector<T> out) throws 
Exception;
+    void deserialize(Message<?> message, Collector<T> out) throws Exception;

Review comment:
       This is a `PublicEvolving` interface, change the method should add 
another method and add a `Deprecated` annotation for old method.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to