Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75448294
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/ComponentMetricGroup.java
---
@@ -33,19 +36,42 @@
* group could for example include the task attempt number (more fine
grained identification), or
* exclude it (for continuity of the namespace across failure and
recovery).
*/
-public abstract class ComponentMetricGroup extends AbstractMetricGroup {
+public abstract class ComponentMetricGroup<P extends AbstractMetricGroup>
extends AbstractMetricGroup<P> {
--- End diff --
The `JobMetricGroup` is annotated as `internal`. I was just wondering
whether we should do the same for this metric group and the others (to which it
applies) as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
