[
https://issues.apache.org/jira/browse/FLINK-26686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Wysakowicz updated FLINK-26686:
-------------------------------------
Description:
Following FLINK-26418, maybe it's a good idea to not expose a constructor for
{{TestingTaskManagerRuntimeInfo}} without the *tmpWorkingDirectory* as this
ends up in creating the ROCKSDB folders inside */tmp* (which at least is an
improvement over having them created in the given {*}CWD{*}, ending up in the
root folder of each given module (i.e: {*}flink-table/flink-table-planner{*}).
If the *tmpWorkingDirectory* is a mandatory argument then the consumers (IT
tests) would have to provide this directory and they can use the standard junit
*TemporaryFolder.newFolder()* so that the directories are automatically deleted
after the tests are run, and devs can find those directories under the
build/test folder of each module and not in an unorganized structure in */tmp*
(or windows user's tmp folder).
was:
Following FLINK-26418, maybe it's a good idea to not expose a constructor
without the *tmpWorkingDirectory* as this ends up in creating the ROCKSDB
folders inside */tmp* (which at least is an improvement over having them
created in the given {*}CWD{*}, ending up in the root folder of each given
module (i.e: {*}flink-table/flink-table-planner{*}).
If the *tmpWorkingDirectory* is a mandatory argument then the consumers (IT
tests) would have to provide this directory and they can use the standard junit
*TemporaryFolder.newFolder()* so that the directories are automatically deleted
after the tests are run, and devs can find those directories under the
build/test folder of each module and not in an unorganized structure in */tmp*
(or windows user's tmp folder).
> Use a junit temp folder for TestingTaskManagerRuntimeInfo tmpWorkingDirectory
> -----------------------------------------------------------------------------
>
> Key: FLINK-26686
> URL: https://issues.apache.org/jira/browse/FLINK-26686
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Configuration
> Reporter: Marios Trivyzas
> Priority: Major
>
> Following FLINK-26418, maybe it's a good idea to not expose a constructor for
> {{TestingTaskManagerRuntimeInfo}} without the *tmpWorkingDirectory* as this
> ends up in creating the ROCKSDB folders inside */tmp* (which at least is an
> improvement over having them created in the given {*}CWD{*}, ending up in the
> root folder of each given module (i.e: {*}flink-table/flink-table-planner{*}).
> If the *tmpWorkingDirectory* is a mandatory argument then the consumers (IT
> tests) would have to provide this directory and they can use the standard
> junit *TemporaryFolder.newFolder()* so that the directories are automatically
> deleted after the tests are run, and devs can find those directories under
> the build/test folder of each module and not in an unorganized structure in
> */tmp* (or windows user's tmp folder).
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
