XComp opened a new pull request #19121:
URL: https://github.com/apache/flink/pull/19121
This can happen if cleanup is triggered after a
failover of a dirty JobResultStore entry (i.e. of
a globally-terminated job). In that case, no
recovery of the JobGraph happens and, therefore, no
JobGraph is added to the internal addedJobGraphs
collection.
## What is the purpose of the change
There's no need to check the `addedJobGraphs` because
`StateHandleStore.releaseAndTryRemove` was made idempotent in FLINK-26284 and
FLINK-26286. Removing a non-existing JobID from the
`DefaultJobGraphStore.addedJobGraphs` works without problems as well.
## Brief change log
* Removed the if clause
## Verifying this change
* `DefaultJobGraphStoreTest.testGlobalCleanupWithNonExistName` was adapted
and `DefaultJobGraphStoreTest.testGlobalCleanupFailsIfRemovalReturnsFalse` to
verify that globalCleanup works as expected
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
