[
https://issues.apache.org/jira/browse/FLINK-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427931#comment-15427931
]
ASF GitHub Bot commented on FLINK-4322:
---------------------------------------
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2385
I will merge this and add the following test for min pause. This fails with
the current master, but works with your PR.
```java
/**
* Tests that no minimum delay between savepoints is enforced.
*/
@Test
public void testMinDelayBetweenSavepoints() throws Exception {
JobID jobId = new JobID();
final ExecutionAttemptID attemptID1 = new ExecutionAttemptID();
ExecutionVertex vertex1 = mockExecutionVertex(attemptID1);
CheckpointCoordinator coord = new CheckpointCoordinator(
jobId,
100000,
200000,
100000000L, // very long min delay => should not affect
savepoints
1,
42,
new ExecutionVertex[] { vertex1 },
new ExecutionVertex[] { vertex1 },
new ExecutionVertex[] { vertex1 },
cl,
new StandaloneCheckpointIDCounter(),
new StandaloneCompletedCheckpointStore(2, cl),
new HeapSavepointStore(),
new DisabledCheckpointStatsTracker());
Future<String> savepoint0 = coord.triggerSavepoint(0);
assertFalse("Did not trigger savepoint", savepoint0.isCompleted());
Future<String> savepoint1 = coord.triggerSavepoint(1);
assertFalse("Did not trigger savepoint", savepoint1.isCompleted());
}
```
> Unify CheckpointCoordinator and SavepointCoordinator
> ----------------------------------------------------
>
> Key: FLINK-4322
> URL: https://issues.apache.org/jira/browse/FLINK-4322
> Project: Flink
> Issue Type: Improvement
> Components: State Backends, Checkpointing
> Affects Versions: 1.1.0
> Reporter: Stephan Ewen
> Assignee: Stephan Ewen
> Fix For: 1.2.0
>
>
> The Checkpoint coordinator should have the functionality of both handling
> checkpoints and savepoints.
> The difference between checkpoints and savepoints is minimal:
> - savepoints always write the root metadata of the checkpoint
> - savepoints are always full (never incremental)
> The commonalities are large
> - jobs should be able to resume from checkpoint or savepoints
> - jobs should fall back to the latest checkpoint or savepoint
> This subsumes issue https://issues.apache.org/jira/browse/FLINK-3397
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
