[ 
https://issues.apache.org/jira/browse/FLINK-26698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yang Wang updated FLINK-26698:
------------------------------
    Description: 
 
{code:java}
/**
     * Given a job ID, construct the path for a dirty entry corresponding to it 
in the job result
     * store.
     *
     * @param jobId The job ID to construct a dirty entry path from.
     * @return A path for a dirty entry for the given the Job ID.
     */
    private Path constructDirtyPath(JobID jobId) {
        return new Path(this.basePath.getPath(), jobId.toString() + 
DIRTY_FILE_EXTENSION);
    } {code}
 

Just like above piece of code, we are using {{{}this.basePath.getPath(){}}}, 
not directly use {{this.basePath}} when create a new Path. I am afraid this 
will cause scheme lost and cause issue when some filesystem implementation 
tries to stat the path.

  was:
 
{code:java}
/**
     * Given a job ID, construct the path for a dirty entry corresponding to it 
in the job result
     * store.
     *
     * @param jobId The job ID to construct a dirty entry path from.
     * @return A path for a dirty entry for the given the Job ID.
     */
    private Path constructDirtyPath(JobID jobId) {
        return new Path(this.basePath.getPath(), jobId.toString() + 
DIRTY_FILE_EXTENSION);
    } {code}
 

 

Just like above piece of code, we are using {{{}this.basePath.getPath(){}}}, 
not directly use {{this.basePath}} when create a new Path. I am afraid this 
will cause scheme lost and cause issue when some filesystem implementation 
tries to stat the path.


> FileSystemJobResultStore#constructDirtyPath might lost the scheme
> -----------------------------------------------------------------
>
>                 Key: FLINK-26698
>                 URL: https://issues.apache.org/jira/browse/FLINK-26698
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Coordination
>            Reporter: Yang Wang
>            Priority: Blocker
>             Fix For: 1.15.0
>
>
>  
> {code:java}
> /**
>      * Given a job ID, construct the path for a dirty entry corresponding to 
> it in the job result
>      * store.
>      *
>      * @param jobId The job ID to construct a dirty entry path from.
>      * @return A path for a dirty entry for the given the Job ID.
>      */
>     private Path constructDirtyPath(JobID jobId) {
>         return new Path(this.basePath.getPath(), jobId.toString() + 
> DIRTY_FILE_EXTENSION);
>     } {code}
>  
> Just like above piece of code, we are using {{{}this.basePath.getPath(){}}}, 
> not directly use {{this.basePath}} when create a new Path. I am afraid this 
> will cause scheme lost and cause issue when some filesystem implementation 
> tries to stat the path.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to