[
https://issues.apache.org/jira/browse/FLINK-26695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508029#comment-17508029
]
Matthias Pohl edited comment on FLINK-26695 at 3/17/22, 7:59 AM:
-----------------------------------------------------------------
[~wangyang0918] you might be right. The fabric8 JavaDoc stays kind of vague on
the return value, though. See
[Deletable.java:25|https://github.com/fabric8io/kubernetes-client/blob/master/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/Deletable.java#L25].
We might want to harden our implementation in that regard to be sure that the
ConfigMap is actually non-existent anymore. WDYT?
was (Author: mapohl):
[~wangyang0918] you might be right. The fabric8 JavaDoc stays kind of vague on
the return value, though. See
[Deletable.java:25|https://github.com/fabric8io/kubernetes-client/blob/master/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/dsl/Deletable.java#L25].
We might want to harden our implementation in that regard to be sure that the
ConfigMap is actually non-existent anymore.
> Fabric8FlinkKubeClient.deleteConfigMap and deleteConfigMapsByLabels don't
> necessarily fail if the deletion didn't succeed
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-26695
> URL: https://issues.apache.org/jira/browse/FLINK-26695
> Project: Flink
> Issue Type: Bug
> Components: Deployment / Kubernetes, Runtime / Coordination
> Affects Versions: 1.15.0, 1.16.0
> Reporter: Matthias Pohl
> Priority: Major
>
> {{Fabric8FlinkKubeClient.deleteConfigMap}} and {{deleteConfigMapsByLabels}}
> do not evaluate the return value and, therefore, might miss an error during
> deletion.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
