[
https://issues.apache.org/jira/browse/FLINK-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428109#comment-15428109
]
ASF GitHub Bot commented on FLINK-4431:
---------------------------------------
Github user ramkrish86 commented on the issue:
https://github.com/apache/flink/pull/2390
+1. Very useful one. Also I saw some of the interfaces though they are
supposed to be Public it is not marked with those types. Is it better to fix
all of them ? Or add a test case that ensures that any new class/existing class
if it misses annotation either Public or Private or what ever could be a new
type, then we should fail the build. We have such a procedure in our project.
Sorry if this is offtopic. Just thought of it so saying here.
> Introduce a "VisibleForTesting" annotation
> ------------------------------------------
>
> Key: FLINK-4431
> URL: https://issues.apache.org/jira/browse/FLINK-4431
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Reporter: Stephan Ewen
> Assignee: Stephan Ewen
> Priority: Minor
> Fix For: 1.2.0
>
>
> I suggest to introduce a {{VisibleForTesting}} annotation in the
> {{flink-annotations}} project.
> Adding this annotation to methods that are really only in place for testing
> is very useful feature. Currently, we depend on Guava for that. Having a
> guava dependency for a documentation annotation class seems a bit much.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
