LadyForest commented on a change in pull request #48:
URL: https://github.com/apache/flink-table-store/pull/48#discussion_r828909245
##########
File path:
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/TableStoreFactory.java
##########
@@ -197,12 +199,42 @@ public DynamicTableSink createDynamicTableSink(Context
context) {
// ~ Tools
------------------------------------------------------------------
- private static LogStoreTableFactory createLogStoreTableFactory(Context
context) {
- return discoverLogStoreFactory(
- context.getClassLoader(),
- context.getCatalogTable()
- .getOptions()
- .getOrDefault(LOG_SYSTEM.key(),
LOG_SYSTEM.defaultValue()));
+ private static Optional<LogStoreTableFactory>
createOptionalLogStoreFactory(Context context) {
+ Configuration options = new Configuration();
+ context.getCatalogTable().getOptions().forEach(options::setString);
+
+ if (!options.get(CHANGE_TRACKING)) {
+ return Optional.empty();
+ }
+
+ if (options.get(LOG_SYSTEM) == null) {
+ // Use file store continuous reading
Review comment:
Correct me if I'm wrong, the comment is not that accurate, should be `//
Use file store reading` because the execution mode might be batch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
