dianfu commented on a change in pull request #19008:
URL: https://github.com/apache/flink/pull/19008#discussion_r828950527
##########
File path:
flink-python/pyflink/fn_execution/datastream/window/merging_window_set.py
##########
@@ -102,7 +102,7 @@ def add_window(self, new_window: W, merge_function:
MergeFunction[W]):
self._mapping[merge_result] = merged_state_window
merged_state_windows.remove(merged_state_window)
- if merge_result not in merged_windows and len(merged_windows) == 1:
+ if merge_result not in merged_windows or len(merged_windows) == 1:
Review comment:
```suggestion
if merge_result not in merged_windows or len(merged_windows) !=
1:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
