realdengziqi commented on a change in pull request #18982:
URL: https://github.com/apache/flink/pull/18982#discussion_r829203216
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/windows/TimeWindow.java
##########
@@ -262,6 +262,12 @@ public int compare(TimeWindow o1, TimeWindow o2) {
* @return window start
*/
public static long getWindowStartWithOffset(long timestamp, long offset,
long windowSize) {
- return timestamp - (timestamp - offset + windowSize) % windowSize;
+ long remainder = (timestamp - offset) % windowSize;
Review comment:
It has been modified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
