JingGe commented on a change in pull request #19084:
URL: https://github.com/apache/flink/pull/19084#discussion_r829187419
##########
File path:
flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchWriterITCase.java
##########
@@ -239,9 +271,9 @@ void testCurrentSendTime() throws Exception {
boolean flushOnCheckpoint,
BulkProcessorConfig bulkProcessorConfig,
SinkWriterMetricGroup metricGroup) {
- return new ElasticsearchWriter<Tuple2<Integer, String>>(
+ return new ElasticsearchWriter<>(
Collections.singletonList(HttpHost.create(ES_CONTAINER.getHttpHostAddress())),
- TestEmitter.jsonEmitter(index, context.getDataFieldName()),
+ new UpdatingEmitter(index, context.getDataFieldName()),
Review comment:
Excellent idea to perform the test cases!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
