fapaul commented on a change in pull request #18345:
URL: https://github.com/apache/flink/pull/18345#discussion_r829787362
##########
File path:
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/cursor/StopCursor.java
##########
@@ -71,7 +71,7 @@ static StopCursor afterMessageId(MessageId messageId) {
return new MessageIdStopCursor(messageId, false);
}
- static StopCursor atEventTime(long timestamp) {
+ static StopCursor atPublishTime(long timestamp) {
Review comment:
Good point with the visibility. I think it would be also good to add
some doc strings for the static methods to symbol they are supposed to be used
by users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
