MartijnVisser commented on a change in pull request #19139:
URL: https://github.com/apache/flink/pull/19139#discussion_r829780185
##########
File path:
flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/catalog/PostgresCatalogTestBase.java
##########
@@ -37,9 +40,12 @@
/** Test base for {@link PostgresCatalog}. */
public class PostgresCatalogTestBase {
+ public static final Logger LOG =
LoggerFactory.getLogger(PostgresCatalogTestBase.class);
+
@Rule public ExpectedException exception = ExpectedException.none();
- @ClassRule public static SingleInstancePostgresRule pg =
EmbeddedPostgresRules.singleInstance();
+ protected static final DockerImageName POSTGRES_96_IMAGE =
+ DockerImageName.parse("postgres:9.6.12");
Review comment:
We should define the used version like the others in
https://github.com/apache/flink/blob/master/flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/util/DockerImageVersions.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
