XComp opened a new pull request #19153: URL: https://github.com/apache/flink/pull/19153
## What is the purpose of the change The only issue where we can run into this right now is where the k8s API returns 404 which is quite unlikely to happen. But still it's good to have the implementation harden for such cases. The `deleteConfigMapByLabels` implementation couldn't be tested like that due to a bug in the fabric8 code: See issue [fabric8io/kubernetes-client issue #3982](https://github.com/fabric8io/kubernetes-client/issues/3982) ## Brief change log Added evaluation around the delete return value. ## Verifying this change * Added tests for non-existing ConfigMap deletion (not related to the change) * Added test for error case where the HTTP request responding with 404 which is the only case where the delete returns `false` * Disabled the test that's not working because of issue mentioned above ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
