[
https://issues.apache.org/jira/browse/FLINK-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428874#comment-15428874
]
Stephan Ewen commented on FLINK-4433:
-------------------------------------
Let's tackle those as independent issues. I think for some of them, it is a
more straightforward decision and fix then for others.
> Refactor the StreamSource.
> --------------------------
>
> Key: FLINK-4433
> URL: https://issues.apache.org/jira/browse/FLINK-4433
> Project: Flink
> Issue Type: Bug
> Reporter: Kostas Kloudas
>
> With the addition of continuous file monitoring, apart from the
> {{StreamSource}} also the {{ContinuousFileReaderOperator}} uses a
> {{SourceContext}}. Given this, all the implementations of the
> {{SourceContext}} should be removed from the {{StreamSource}} and become
> independent classes.
> In addition, the {{AsyncExceptionChecker}} interface should be removed as its
> functionality can be replaced by the {{task.failExternally()}} method. This
> also implies slight changes in the source context implementations.
> Also in the {{trigger()}} method of the {{WatermarkEmittingTask}}, all the
> {{owner.getCurrentProcessingTime()}} could be replaced by the {{timestamp}}
> argument of that method. This will remove some of the calls to the
> {{getCurrentProcessingTime()}} which can be expensive.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
