zentol commented on a change in pull request #18848:
URL: https://github.com/apache/flink/pull/18848#discussion_r829020911
##########
File path:
flink-rpc/flink-rpc-akka/src/test/java/org/apache/flink/runtime/rpc/akka/MessageSerializationTest.java
##########
@@ -65,21 +60,20 @@ public static void setup() throws Exception {
.createAndStart();
}
- @AfterClass
- public static void teardown()
+ @AfterAll
+ private static void teardown()
throws InterruptedException, ExecutionException, TimeoutException {
final Collection<CompletableFuture<?>> terminationFutures = new
ArrayList<>(2);
terminationFutures.add(akkaRpcService1.stopService());
terminationFutures.add(akkaRpcService2.stopService());
- FutureUtils.waitForAll(terminationFutures)
- .get(timeout.toMilliseconds(), TimeUnit.MILLISECONDS);
+ FutureUtils.waitForAll(terminationFutures).get();
Review comment:
We decided to not use timeouts in tests.
##########
File path:
flink-rpc/flink-rpc-akka/src/test/java/org/apache/flink/runtime/concurrent/akka/ClassLoadingUtilsTest.java
##########
@@ -48,14 +46,14 @@ public void testRunnableWithContextClassLoader() throws
Exception {
ClassLoadingUtils.withContextClassLoader(runnable,
TEST_CLASS_LOADER);
// the runnable should only be wrapped, not run immediately
- assertThat(contextClassLoader.isDone(), is(false));
+ assertThat(contextClassLoader.isDone()).isFalse();
wrappedRunnable.run();
- assertThat(contextClassLoader.get(), is(TEST_CLASS_LOADER));
+ assertThat(contextClassLoader.get()).isSameAs(TEST_CLASS_LOADER);
Review comment:
We decided to not use timeouts in tests; I'll stick to the original
because specifying an infinite timeout just means additional noise in the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
