twalthr commented on a change in pull request #19147:
URL: https://github.com/apache/flink/pull/19147#discussion_r829873644
##########
File path: flink-python/pyflink/table/table_environment.py
##########
@@ -1668,7 +1668,10 @@ def create(stream_execution_environment:
StreamExecutionEnvironment = None, # t
>>> table_config = TableConfig()
>>> table_env = StreamTableEnvironment.create(env, table_config)
# create with StreamExecutionEnvironment and EnvironmentSettings.
- >>> environment_settings = EnvironmentSettings.in_streaming_mode()
+ >>> configuration = Configuration()
+ >>> configuration.set_string('execution.buffer-timeout', '1 min')
+ >>> environment_settings = EnvironmentSettings.new_instance()
Review comment:
can we improve the indention here e.g. new line before
`.with_configuration`
##########
File path: flink-python/pyflink/table/table_environment.py
##########
@@ -1668,7 +1668,10 @@ def create(stream_execution_environment:
StreamExecutionEnvironment = None, # t
>>> table_config = TableConfig()
>>> table_env = StreamTableEnvironment.create(env, table_config)
# create with StreamExecutionEnvironment and EnvironmentSettings.
- >>> environment_settings = EnvironmentSettings.in_streaming_mode()
+ >>> configuration = Configuration()
Review comment:
`create with StreamExecutionEnvironment and TableConfig.` is outdated
##########
File path: flink-python/pyflink/table/table_environment.py
##########
@@ -1664,11 +1663,13 @@ def create(stream_execution_environment:
StreamExecutionEnvironment = None, # t
# create with StreamExecutionEnvironment.
>>> env = StreamExecutionEnvironment.get_execution_environment()
>>> table_env = StreamTableEnvironment.create(env)
- # create with StreamExecutionEnvironment and TableConfig.
- >>> table_config = TableConfig()
- >>> table_env = StreamTableEnvironment.create(env, table_config)
# create with StreamExecutionEnvironment and EnvironmentSettings.
- >>> environment_settings = EnvironmentSettings.in_streaming_mode()
+ >>> configuration = Configuration()
+ >>> configuration.set_string('execution.buffer-timeout', '1 min')
+ >>> environment_settings = EnvironmentSettings
+ >>> .new_instance()
+ >>> .in_streaming_mode()
+ >>> .with_configuration(configuration)
Review comment:
is there no `build()` method at the end?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
