[ 
https://issues.apache.org/jira/browse/FLINK-26655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Biao Geng updated FLINK-26655:
------------------------------
    Description: 
-We now consider that JM pod can have 2 possible states after launching:-
 # -JM is launched but port is not ready.-
 # -JM is launched, port is ready but rest service is not ready.-

-It looks that they can be merged as what we really care is if the JM can serve 
REST calls correctly, not if the JM port is ready.-
-With above observation, we can merge {{isJobManagerPortReady}} and 
{{isJobManagerServing}} to check if JM pod can serve correctly.-

 

Following the discussion in PR 
[62|https://github.com/apache/flink-kubernetes-operator/pull/62], we currently 
discard {{isJobManagerServing}}  and use the {{isJobManagerPortReady}} together 
with a call to `flinkService.listJobs()`to make sure job manager can serve rest 
call correctly. The original question of this jira is solved.
Now I adjust this jira to track the improvement of the observe logic in 
SessionObserver due to the review comments.

  was:
-We now consider that JM pod can have 2 possible states after launching:-
 # -JM is launched but port is not ready.-
 # -JM is launched, port is ready but rest service is not ready.-

-It looks that they can be merged as what we really care is if the JM can serve 
REST calls correctly, not if the JM port is ready.-
-With above observation, we can merge {{isJobManagerPortReady}} and 
{{isJobManagerServing}} to check if JM pod can serve correctly.-

 

Following the discussion in PR 
[62|https://github.com/apache/flink-kubernetes-operator/pull/62], we currently 
discard {{isJobManagerServing}}  and use the {{isJobManagerPortReady}} together 
with a call to `flinkService.listJobs()`to make sure job manager can serve rest 
call correctly. The original question of this jira is solved.
Now I adjust this jira to track the improvement of the 


> Improve the observe logic in SessionObserver
> --------------------------------------------
>
>                 Key: FLINK-26655
>                 URL: https://issues.apache.org/jira/browse/FLINK-26655
>             Project: Flink
>          Issue Type: Sub-task
>            Reporter: Biao Geng
>            Priority: Major
>
> -We now consider that JM pod can have 2 possible states after launching:-
>  # -JM is launched but port is not ready.-
>  # -JM is launched, port is ready but rest service is not ready.-
> -It looks that they can be merged as what we really care is if the JM can 
> serve REST calls correctly, not if the JM port is ready.-
> -With above observation, we can merge {{isJobManagerPortReady}} and 
> {{isJobManagerServing}} to check if JM pod can serve correctly.-
>  
> Following the discussion in PR 
> [62|https://github.com/apache/flink-kubernetes-operator/pull/62], we 
> currently discard {{isJobManagerServing}}  and use the 
> {{isJobManagerPortReady}} together with a call to `flinkService.listJobs()`to 
> make sure job manager can serve rest call correctly. The original question of 
> this jira is solved.
> Now I adjust this jira to track the improvement of the observe logic in 
> SessionObserver due to the review comments.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to