[GitHub] [flink-table-store] LadyForest commented on a change in pull request #55: [hotfix] Optimize getChangelogMode in TableStoreSink and TableStoreSource

Mon, 21 Mar 2022 02:33:10 -0700 


LadyForest commented on a change in pull request #55:
URL: https://github.com/apache/flink-table-store/pull/55#discussion_r830880524



##########
File path: 
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/sink/TableStoreSink.java
##########
@@ -41,12 +42,13 @@
 import java.util.HashMap;
 import java.util.Map;
 
+import static org.apache.flink.table.store.log.LogOptions.CHANGELOG_MODE;
+
 /** Table sink to create {@link StoreSink}. */
 public class TableStoreSink
         implements DynamicTableSink, SupportsOverwrite, SupportsPartitioning, 
RequireCatalogLock {
 
     private final TableStore tableStore;
-    private final LogOptions.LogChangelogMode logChangelogMode;

Review comment:
       L#148, `copy()` should be updated
   
![image](https://user-images.githubusercontent.com/55568005/159231291-d8645409-161f-4ece-98ed-c204d5a799e7.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to