zentol commented on a change in pull request #19191:
URL: https://github.com/apache/flink/pull/19191#discussion_r831159253
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCheckpointIDCounter.java
##########
@@ -118,11 +122,46 @@ public void start() throws Exception {
if (jobStatus.isGloballyTerminalState()) {
LOG.info("Removing {} from ZooKeeper", counterPath);
+ final CompletableFuture<Void> deletionFuture = new
CompletableFuture<>();
try {
- client.delete().inBackground().forPath(counterPath);
+ client.delete()
+ .inBackground(
+ (curatorFramework, curatorEvent) -> {
Review comment:
we could make this more readable by having the runnable be defined in
another method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
