zentol commented on a change in pull request #19191:
URL: https://github.com/apache/flink/pull/19191#discussion_r831235009
##########
File path:
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/highavailability/KubernetesCheckpointIDCounterTest.java
##########
@@ -50,6 +55,126 @@ public void testGetAndIncrement() throws Exception {
};
}
+ @Test
+ public void testShutdown() throws Exception {
+ new Context() {
+ {
+ runTest(
+ () -> {
+ leaderCallbackGrantLeadership();
+
+ final KubernetesCheckpointIDCounter
checkpointIDCounter =
+ new KubernetesCheckpointIDCounter(
+ flinkKubeClient,
LEADER_CONFIGMAP_NAME, LOCK_IDENTITY);
+ checkpointIDCounter.start();
+
+ checkpointIDCounter.setCount(100L);
+
+ assertThat(
+ getLeaderConfigMap()
+ .getData()
+
.get(Constants.CHECKPOINT_COUNTER_KEY),
+ is("100"));
+
+
checkpointIDCounter.shutdown(JobStatus.FINISHED).join();
+
+ assertThat(
+ getLeaderConfigMap()
+ .getData()
+
.containsKey(Constants.CHECKPOINT_COUNTER_KEY),
+ is(false));
+ });
+ }
+ };
+ }
+
+ @Test
+ public void testShutdownForLocallyTerminatedJobStatus() throws Exception {
+ new Context() {
+ {
+ runTest(
+ () -> {
+ leaderCallbackGrantLeadership();
+
+ final KubernetesCheckpointIDCounter
checkpointIDCounter =
+ new KubernetesCheckpointIDCounter(
+ flinkKubeClient,
LEADER_CONFIGMAP_NAME, LOCK_IDENTITY);
+ checkpointIDCounter.start();
+
+ checkpointIDCounter.setCount(100L);
+
+ assertThat(
+ getLeaderConfigMap()
+ .getData()
+
.get(Constants.CHECKPOINT_COUNTER_KEY),
+ is("100"));
+
+
checkpointIDCounter.shutdown(JobStatus.SUSPENDED).join();
+
+ assertThat(
+ getLeaderConfigMap()
+ .getData()
+
.containsKey(Constants.CHECKPOINT_COUNTER_KEY),
+ is(true));
+ });
+ }
+ };
+ }
+
+ @Test
+ public void testIdempotentShutdown() throws Exception {
+ new Context() {
+ {
+ runTest(
+ () -> {
+ leaderCallbackGrantLeadership();
+
+ final KubernetesCheckpointIDCounter
checkpointIDCounter =
+ new KubernetesCheckpointIDCounter(
+ flinkKubeClient,
LEADER_CONFIGMAP_NAME, LOCK_IDENTITY);
+ checkpointIDCounter.start();
+
+ assertThat(
+ getLeaderConfigMap()
+ .getData()
+
.containsKey(Constants.CHECKPOINT_COUNTER_KEY),
+ is(false));
+
+
checkpointIDCounter.shutdown(JobStatus.FINISHED).join();
+
+ assertThat(
+ getLeaderConfigMap()
+ .getData()
+
.containsKey(Constants.CHECKPOINT_COUNTER_KEY),
+ is(false));
+ });
+ }
+ };
+ }
+
+ @Test
+ public void testShutdownFailureDueToMissingConfigMap() throws Exception {
+ new Context() {
+ {
+ runTest(
+ () -> {
+ leaderCallbackGrantLeadership();
+
+ final KubernetesCheckpointIDCounter
checkpointIDCounter =
+ new KubernetesCheckpointIDCounter(
+ flinkKubeClient,
LEADER_CONFIGMAP_NAME, LOCK_IDENTITY);
+ checkpointIDCounter.start();
+
+
flinkKubeClient.deleteConfigMap(LEADER_CONFIGMAP_NAME);
+
+ assertThrows(
+ CompletionException.class,
+ () ->
checkpointIDCounter.shutdown(JobStatus.FINISHED).get());
Review comment:
Well now I'm confused; why is it ok for this shutdown call to fail
because of a missing config map?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
