LadyForest commented on a change in pull request #54:
URL: https://github.com/apache/flink-table-store/pull/54#discussion_r831716142



##########
File path: 
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/TableStore.java
##########
@@ -171,6 +181,83 @@ private FileStore buildFileStore() {
                 tableIdentifier, options, user, partitionType, keyType, 
valueType, mergeFunction);
     }
 
+    // 
--------------------------------------------------------------------------------------------
+
+    /** A builder for constructing a immutable {@link TableStore}. */
+    public static final class TableStoreBuilder {

Review comment:
       > there is no call order
   
   If we put the adjusting and validation in `#withXXX` method, how to make 
sure the `rowType` has been specified already?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to