wenlong88 commented on a change in pull request #19188:
URL: https://github.com/apache/flink/pull/19188#discussion_r832003274
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/ArrayToArrayCastRule.java
##########
@@ -109,7 +110,7 @@ protected String generateCodeBlockInternal(
private static String arrayElementType(LogicalType t) {
if (t.isNullable()) {
Review comment:
IMO, CodeGenUtils.isPrimitiveNullable decides whether a primitiveType
is nullable, if there is a type supports CodeGenUtils.isPrimitiveNullable =
true in the future, we should use primitive type here.
Maybe it is impossible to having such kind of type, you can ignore this
comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
