lindong28 commented on a change in pull request #70: URL: https://github.com/apache/flink-ml/pull/70#discussion_r832799295
########## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/clustering/kmeans/OnlineKMeans.java ########## @@ -0,0 +1,409 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.ml.clustering.kmeans; Review comment: Strictly speaking they are different algorithms due to the following reasons: - When they are given the same bounded training data, KMeans will iterate the data multiple times and OnlineKMeans will iterate the data exactly once. Thus the algorithm is different. And the resulting model data and prediction accuracy will also be different. - They have different behavior in terms of whether they support unbounded training data. You are right that KMeans and OnlineKMeans implementations share some infra codes. But this seems more like an implementation detail that is more related to developer experience. After thinking about this more, I don't have a strong opinion here and both approaches work for me. We can keep it as is and separate them into different packages in the future when needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
