wuchong commented on pull request #19193: URL: https://github.com/apache/flink/pull/19193#issuecomment-1076429247
Thanks @RocMarshal and @lsyldliu for pushing the effort of this feature, and sorry for not joining the discussion early. I agree with @RocMarshal that we should try to discuss on the original issue or PR, so that the later reviewer or contributor can have a full discussion context. It is recommended to Regarding implementation details, I agree with @lsyldliu a 2K lines PR is hard to review. Separating into small PRs is appreciated. And decoupling ADD COLUMN and COLUMN definition logic is also a nice improvement. **How to continue this contribution? ** Considering @lsyldliu has contributed the parser PR, what about let's continue the parser work in this PR. And @RocMarshal can rebase https://github.com/apache/flink/pull/17560 on this PR to focus on the planner part. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
