matriv commented on a change in pull request #19205:
URL: https://github.com/apache/flink/pull/19205#discussion_r833355201
##########
File path:
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdHandlerTestBase.scala
##########
@@ -82,27 +78,18 @@ import scala.collection.JavaConversions._
class FlinkRelMdHandlerTestBase {
val tableConfig = TableConfig.getDefault()
- val rootSchema: SchemaPlus = MetadataTestUtil.initRootSchema()
-
- val catalogManager: CatalogManager =
CatalogManagerMocks.createEmptyCatalogManager()
- val moduleManager = new ModuleManager
// TODO batch RelNode and stream RelNode should have different PlannerContext
// and RelOptCluster due to they have different trait definitions.
- val plannerContext: PlannerContext =
- new PlannerContext(
- false,
- tableConfig,
- moduleManager,
- new FunctionCatalog(tableConfig, catalogManager, moduleManager),
- catalogManager,
- CalciteSchema.from(rootSchema),
- util.Arrays.asList(
- ConventionTraitDef.INSTANCE,
- FlinkRelDistributionTraitDef.INSTANCE,
- RelCollationTraitDef.INSTANCE
- )
- )
+ val plannerContext: PlannerContext = new PlannerMocks.Builder()
Review comment:
sure, +1, didn't think about it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
