pnowojski commented on a change in pull request #19198:
URL: https://github.com/apache/flink/pull/19198#discussion_r833684250
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -1243,7 +1243,7 @@ private void completePendingCheckpoint(PendingCheckpoint
pendingCheckpoint)
// the pending checkpoint must be discarded after the finalization
Preconditions.checkState(pendingCheckpoint.isDisposed() &&
completedCheckpoint != null);
- if (!props.isSavepoint()) {
+ if (!props.isSavepoint() || props.isSynchronous()) {
lastSubsumed =
addCompletedCheckpointToStoreAndSubsumeOldest(
Review comment:
Should we subsume anything in this case? Also isn't this braking
savepoint ownership? I mean what if user deletes the savepoint?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
