Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2389#discussion_r75669856
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/resourcemanager/ResourceManagerGateway.java
 ---
    @@ -53,25 +53,34 @@
        Future<RegistrationResponse> registerJobMaster(JobMasterRegistration 
jobMasterRegistration);
     
        /**
    -    * Requests a slot from the resource manager.
    +    * JobMaster Requests a slot from the resource manager.
         *
         * @param slotRequest Slot request
         * @return Future slot assignment
         */
    -   Future<SlotAssignment> requestSlot(SlotRequest slotRequest);
    +   Future<AcknowledgeSlotRequest> requestSlot(SlotRequest slotRequest);
     
        /**
    -    * 
    -    * @param resourceManagerLeaderId  The fencing token for the 
ResourceManager leader 
    -    * @param taskExecutorAddress      The address of the TaskExecutor that 
registers
    -    * @param resourceID               The resource ID of the TaskExecutor 
that registers
    -    * @param timeout                  The timeout for the response.
    -    * 
    +    *
    --- End diff --
    
    Java docs missing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to