[ 
https://issues.apache.org/jira/browse/FLINK-26843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timo Walther closed FLINK-26843.
--------------------------------
    Fix Version/s: 1.16.0
       Resolution: Fixed

Fixed in master:

commit 3ddd74e9f9b510502c5c4c62eabf6daaaf8d724e
[table-planner] Cleanup TableConfig & ReadableConfig

commit 38217d665a2e441bcf3c91d17b01c1d6a75e220c
[table-planner] Replace `TableConfig` with `ReadableConfig`

commit 075b790b750074570df929cd4d5cd19be52a7199
[table-planner] Use ShortcutUtils.unwrap[TableConfig/Context]

commit 33ce8447e13ffff74e8a15f9df410c228deb39cf
[table-planner] Use TableConfigUtils to get local timezone.

> Cleanup code around TableConfig/ReadableConfig
> ----------------------------------------------
>
>                 Key: FLINK-26843
>                 URL: https://issues.apache.org/jira/browse/FLINK-26843
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table SQL / Planner
>            Reporter: Timo Walther
>            Assignee: Marios Trivyzas
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.16.0
>
>
> - Replace usages of TableConfig#getLocalTimeZone() with 
> TableConfigUtils.getLocalTimeZone(tableConfig) to facilitate passing 
> ReadableConfig instead of concrete TableConfig.
> - Cleanup code by using the utilitty methods of ShortcutUtils: 
> unwrapTableConfig and unwrapContext.
> Replace TableConfig with ReadableConfig where possible, to cleanup the 
> usages, and make sure that TableConfig is only used where it's absolutely 
> necessary, because of the extra functionality it provides.
> - Cleanup usages and naming of variables regarding TableConfig and 
> ReadableConfig to make clear what is used/passed as variables and method args.
> - Cleanup some test code by using PlannerMocks instead of creating 
> PlannerContext manually.
> - Cleanup some test code by using JsonSerdeTestUtil#configuredSerdeContext() 
> to avoid creating SerdeContexts manually.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to