[ 
https://issues.apache.org/jira/browse/FLINK-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430746#comment-15430746
 ] 

ASF GitHub Bot commented on FLINK-4273:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2313#discussion_r75676249
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
    @@ -275,9 +275,35 @@ public static ClassLoader retrieveClassLoader(
        public static JobExecutionResult awaitJobResult(JobListeningContext 
listeningContext) throws JobExecutionException {
     
                final JobID jobID = listeningContext.jobID;
    +           final ActorRef jobClientActor = listeningContext.jobClientActor;
                final Future<Object> jobSubmissionFuture = 
listeningContext.jobResultFuture;
                final ClassLoader classLoader = listeningContext.classLoader;
     
    +           while (!jobSubmissionFuture.isCompleted()) {
    +                   try {
    +                           Thread.sleep(250);
    --- End diff --
    
    My bad, the future was only completed due to some faulty testing code.


> Refactor JobClientActor to watch already submitted jobs 
> --------------------------------------------------------
>
>                 Key: FLINK-4273
>                 URL: https://issues.apache.org/jira/browse/FLINK-4273
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Client
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> The JobClientActor assumes that it receives a job, submits it, and waits for 
> the result. This process should be broken up into a submission process and a 
> waiting process which can both be entered independently. This leads to two 
> different entry points:
> 1) submit(job) -> wait
> 2) retrieve(jobID) -> wait



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to