LadyForest commented on a change in pull request #58:
URL: https://github.com/apache/flink-table-store/pull/58#discussion_r834917705



##########
File path: 
flink-table-store-core/src/test/java/org/apache/flink/table/store/file/utils/BlockingIterator.java
##########
@@ -65,6 +65,15 @@ public BlockingIterator(Iterator<IN> iterator, Function<IN, 
OUT> converter) {
         }
     }
 
+    public List<OUT> collectAndCloseQuietly(int limit) {

Review comment:
       > Why do you want to be quiet? Just throw the exception?
   
   because the `collect()` is direct returns an empty list when the expected 
num is zero. What I want to test is to let time pass by until timeout, to 
verify that it cannot collect even one record.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to