matriv commented on a change in pull request #19232:
URL: https://github.com/apache/flink/pull/19232#discussion_r835086867
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/utils/ExecNodeMetadataUtilTest.java
##########
@@ -218,7 +331,11 @@ public void testStreamExecNodeJsonSerdeCoverage() {
@ExecNodeMetadata(
name = "dummy-node",
version = 3,
- consumedOptions = {"table.exec.state.ttl",
"table.exec.sink.not-null-enforcer"},
+ consumedOptions = {
+ "table.exec.state.ttl",
+ "table.exec.sink.not-null-enforcer",
+
"table.exec.deduplicate.mini-batch.compact-changes.enabled" // deprecated key
Review comment:
Here I need real keys, because those keys, in order to be returned in
the persistedConfiguration they need to be in the `TableConfigOptions` and
`ExecutionConfigOptions`, and I wanted to also test the deprecated keys.
A workaround would be to add some package private methods that add dummy
keys to those static maps, so I can use them in the test, or do you maybe have
any better suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
