twalthr commented on a change in pull request #19232:
URL: https://github.com/apache/flink/pull/19232#discussion_r835292202
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/utils/ExecNodeMetadataUtilTest.java
##########
@@ -513,4 +501,21 @@ protected AbstractDummyNode(
return null;
}
}
+
+ private static final ConfigOption<Integer> OPTION_1 =
+
key("option1").intType().defaultValue(-1).withDescription("option1");
+ private static final ConfigOption<Integer> OPTION_2 =
+
key("option2").intType().defaultValue(-1).withDescription("option2");
+ private static final ConfigOption<Integer> OPTION_3 =
+ key("option3")
+ .intType()
+ .defaultValue(-1)
+ .withDeprecatedKeys("option3-deprecated")
+ .withDescription("option3");
+ private static final ConfigOption<Integer> OPTION_4 =
+ key("option4")
+ .intType()
+ .defaultValue(-1)
+ .withDeprecatedKeys("option4-fallback")
Review comment:
this should be `withFallback`?
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/utils/ExecNodeMetadataUtilTest.java
##########
@@ -319,23 +311,19 @@ public void testStreamExecNodeJsonSerdeCoverage() {
@ExecNodeMetadata(
name = "dummy-node",
version = 1,
- consumedOptions = {"option1", "option2"},
+ consumedOptions = {"option11", "option22", "option33"},
minPlanVersion = FlinkVersion.v1_13,
minStateVersion = FlinkVersion.v1_13),
@ExecNodeMetadata(
name = "dummy-node",
version = 2,
- consumedOptions = {"option11", "option22"},
+ consumedOptions = {"option111", "option222", "option333"},
minPlanVersion = FlinkVersion.v1_14,
minStateVersion = FlinkVersion.v1_14),
@ExecNodeMetadata(
name = "dummy-node",
version = 3,
- consumedOptions = {
- "table.exec.state.ttl",
- "table.exec.sink.not-null-enforcer",
-
"table.exec.deduplicate.mini-batch.compact-changes.enabled" // deprecated key
- },
+ consumedOptions = {"option1", "option2", "option3-deprecated",
"option4-fallback"},
Review comment:
let's represent the reality here, the version 1 uses a deprecated key
that is a new key in version 2 or 3?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
