matriv opened a new pull request #19262:
URL: https://github.com/apache/flink/pull/19262


   
   ## What is the purpose of the change
   
   Small code improvements around test in `flink-table` module
   
   ## Brief change log
   
     - Since `table.exec.legacy-cast-behaviour` is disabled by default, there 
is no need to explicitely set it in the configuration of the Cast related IT 
tests.
     - Call `super.getConfiguration()` to inherit the configuration set in the 
superclass and add/override with more config options in the subclass.
     - Fix warnings
     - Use assertJ
     - Remove unused code
     - Replace deprecated ExpectedException with assertJ's `assertThatThrownBy` 
and improve certain assertions by asserting the Exception class or the 
Exception message where missing.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **not applicable**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to